fix(types): add missing standard properties to URL and URLSearchParams #54787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
|
@alanleedev has imported this pull request. If you are a Meta employee, you can view this in D88517037. |
|
@alanleedev merged this pull request in f97b9a5. |
Collaborator
|
This pull request was successfully merged by Manish Balayan in f97b9a5 When will my fix make it into a release? | How to file a pick request? |
Contributor
|
@manishbalayan thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR related to issue #54789 updates the
URLandURLSearchParamsdefinitions inglobals.d.tsto include missing standard properties and methods that are already supported by the runtime implementation.Motivation:
I noticed that while the runtime supports standard URL operations (backed by
whatwg-url), the TypeScript definitions were incomplete, causing unnecessary type errors when using standard Web APIs.Changelog:
[GENERAL] [FIXED] - Added missing standard properties to
URL(hash, host, pathname, etc.) and methods toURLSearchParams(get, set, delete, etc.).Test Plan:
globals.d.ts.URLinterface now includes all standard properties.URLSearchParamsinterface now includes all standard methods.Screenshot:
Before making changes